Kb exit toolbox #2398
Merged
Kb exit toolbox #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Desired functionality for keyboard navigation.
Proposed Changes
Move cursor to workspace when E pressed in toolbox or flyout.
Add
shouldHideparam toBlockly.Navigation.resetFlyout.If there was a selected block on the workspace the cursor goes to that block. Otherwise it goes to a fixed location on the workspace.
Add a test file for navigation, and a basic test.
Stub
getMainWorkspacefor AST Node tests, and restore it at the end of the tests.Reason for Changes
We needed a way to exit the flyout/toolbox without inserting a block.
Test Coverage
Added mocha test.