Set node version explicitly for travis; update dependencies #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
Apr 23, 2019
|
Test setup is working but generator and jsunit tests are failing. |
|
Passing after a rebuild, when running under 8 and 10. |
rachel-fenichel
added a commit
to rachel-fenichel/blockly
that referenced
this pull request
Apr 23, 2019
* Set node version explicitly for travis * rebuild * Tweak travis config
alschmiedt
pushed a commit
that referenced
this pull request
Apr 26, 2019
* Set node version explicitly for travis * rebuild * Tweak travis config
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Broken builds
Proposed Changes
Set node version explicitly for travis; update dependencies
Reason for Changes
Something in gulp seems broken with node v12, which is stable as of today. I'm moving us to testing against the main LTS branches.
Test Coverage
Travis.