Removed setVisible (fields, inputs) from the Public API

[BeksOmega]

The basics

• I branched from develop
• My pull request is against develop
• My code follows the style guide

The details

Resolves

#2381

Proposed Changes

Removes setVisible from the public API. This change applies to inputs and fields but not from icons (comments, mutators, warnings, etc), scrollbars, flyouts, or workspaces.

In doing so this removes a setVisible call from the procedures_defnoreturn block.

Also cleans up setVisible within fields. Some of the setVisible logic was leaking into the render() function because of the old way of re-rendering fields (setting their width to zero) it has now been moved back to the setVisible function.

Reason for Changes

Set visible should not be used to hide fields or inputs, it should only be used when collapsing a block.

Test Coverage

Tested collapsing blocks:

Tested the procedure block mutator:
On Develop:

On This Branch:

Tested on:

• Desktop Chrome
• Desktop Firefox

• Windows Internet Explorer 11
• Windows Edge

Additional Information

N/A