Add a marker that shows where the user has marked on the workspace #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alschmiedt
approved these changes
Apr 29, 2019
core/navigation.js
Outdated
| var position = markedNode.getWsCoordinate(); | ||
| newBlock.moveTo(position); | ||
|
|
||
| // Move the cursor toe the right place on the inserted block. |
core/navigation.js
Outdated
| @@ -297,6 +313,10 @@ Blockly.Navigation.insertFromFlyout = function() { | |||
| //TODO: IF this is null then we need to add to the correct place on the | |||
There was a problem hiding this comment.
Can we remove this TODO since I think it is taken care of in insertBlockToWs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Progress on keyboard navigation.
Proposed Changes
Add a
markerto the workspace as well as thecursor. Amarkeris a type ofcursorSvgthat cannot be moved with prev/next/in/out. It can only be moved directly to known locations withsetLocation.When the user hits enter to mark a location on the workspace or a connection on a block, the marker renders. It disappears again when the user inserts a block at that marker.
Reason for Changes
It's important to know where your insertion location is when you're inserting blocks.
Test Coverage
Tested in Chrome