Reduce ID collisions. #2429
Merged
Reduce ID collisions. #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches code in Blockly Games. No functional change.
Previously, if the XML of a toolbox contained a block ID, the first creation of this block would inherit this ID. Thus two realtime collaborators could realistically end up with conflict. Likewise, cut and paste could generate similar conflict.
I don’t care about whether we use the Element constants or the ubiquitously known 1 & 3 integers. But we had a mix. Also, ’x’ is usually used for horizontal location, ‘i’ is an iterator. No functional change.
RoboErikG
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realtime collaborators are liable to independently generate blocks with the same IDs due to the IDs being encoded in XML. This PR fixes IDs in toolboxes and IDs in cut/copy/paste.
Also included are a couple of other minor cleanup commits that result in no functional changes.