Next cleanup #2431
Merged
Next cleanup #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
May 2, 2019
core/ast_node.js
Outdated
| * @param {Blockly.Input} parentInput The parent input of the connection. | ||
| * @return {Blockly.ASTNode} The ast node holding the next field or connection. | ||
| * Given an input find the next editable field or an input with a non null | ||
| * connection. |
There was a problem hiding this comment.
nit, add "in the same block."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Fixes next functionality for fields and inputs.
Makes navigateBetweenStacks return null if it gets to the last stack in the workspace instead of wrapping.
Cleans up next, previous, and block functionality.
Reason for Changes
Test Coverage
Tests written in mocha.
Tested on:
Additional Information