Cleanup for previous #2436
Merged
Cleanup for previous #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current failing mocha tests were failing from before. Will fix them in a different PR. |
core/ast_node.js
Outdated
| * @param {Blockly.Input} parentInput Parent input of the connection or field. | ||
| * Given an input find the previous editable field or an input with a non null | ||
| * connection in the same block. | ||
| * @param {!Blockly.Input} location Current location in the ast. |
There was a problem hiding this comment.
Phrasing: AST nodes are locations in the AST, but I don't think an input is.
There was a problem hiding this comment.
Eh, it's not the node itself, but it does uniquely identify a position in the AST.
RoboErikG
reviewed
May 3, 2019
core/ast_node.js
Outdated
| * @param {Blockly.Input} parentInput Parent input of the connection or field. | ||
| * Given an input find the previous editable field or an input with a non null | ||
| * connection in the same block. | ||
| * @param {!Blockly.Input} location Current location in the ast. |
There was a problem hiding this comment.
Eh, it's not the node itself, but it does uniquely identify a position in the AST.
rachel-fenichel
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Reason for Changes
Test Coverage
Tests written in mocha.
Tested on:
Additional Information