Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper to check whether an ast node points to a connection #2438

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

Store whether an ast node points to a connection on the node, and add a getter.

This is a pretty common check and easy to know from the type.

Reason for Changes

Helper function

Test Coverage

Added checks to the ast node constructor tests.

Copy link
Contributor

@RoboErikG RoboErikG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary if we're getting rid of insertionNode_ or is it still useful for the tests?

Copy link
Contributor

@RoboErikG RoboErikG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if it's still helpful then lgtm.

@rachel-fenichel rachel-fenichel merged commit a0e6226 into google:keyboard_nav May 3, 2019
@rachel-fenichel rachel-fenichel deleted the feature/astnode_isconnection branch October 17, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants