Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fixes and cleanup #2442

Merged
merged 2 commits into from
May 6, 2019
Merged

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

Changes include:

  1. Fixes block being positioned incorrectly when an output connection is selected
  2. Deselects the selected block when in accessibility mode
  3. Removes CURSOR_REFERENCE
  4. Adds getOffsetInBlock so we don't have to use private variables

Reason for Changes

Test Coverage

Tested on:

Additional Information

/**
* Get the offset of this connection relative to the top left of its block.
* @return {!goog.math.Coordinate} The offset of the connection.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark this @Package.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After that, lgtm.

@alschmiedt alschmiedt merged commit 395bcd8 into google:keyboard_nav May 6, 2019
@alschmiedt alschmiedt deleted the small_cleanup branch May 29, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants