Changes the cursor look for a stack #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/cursor_svg.js
Outdated
| Blockly.CursorSvg.prototype.showWithStack_ = function() { | ||
| var block = this.getCurNode().getLocation(); | ||
|
|
||
| //Gets the height and width of entire stack |
There was a problem hiding this comment.
General formatting comment: single line comments should have a space after the second slash, and a period at the end. As usual for this sort of stuff, apply it to the lines you touched here and change existing ones as you touch them in other PRs.
rachel-fenichel
approved these changes
May 8, 2019
RoboErikG
reviewed
May 8, 2019
core/cursor_svg.js
Outdated
|
|
||
| //If the block has an output connection it needs more padding | ||
| if (block.outputConnection) { | ||
| x = -1 * Blockly.CursorSvg.STACK_PADDING; |
There was a problem hiding this comment.
Should this be x -= Blockly.BlockSvg.TAB_WIDTH; and do you need to add the tab width to the cursor width or is it calculated in the block's width but drawn with a - offset?
There was a problem hiding this comment.
Yes to the first part, but I think the TAB_WIDTH is included when we get the width for the entire block so we just need to change where it is positioned.
RoboErikG
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Having the cursor for a stack and a block be the same can be pretty confusing when trying to navigate through the blocks.
Proposed Changes
Make the cursor for a stack cover the entire stack of blocks as well as make it slightly cover a slightly larger area than the block.
Reason for Changes
Test Coverage
Tested on:
Additional Information