Accessibility demo #2466
Merged
Accessibility demo #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
May 16, 2019
| Blockly.Xml.domToWorkspace(document.getElementById('startBlocks'), | ||
| demoWorkspace); | ||
|
|
||
| function validNode(node) { |
There was a problem hiding this comment.
Document functions with explanations of what each function does. Demos are better if they include extra documentation. ;)
demos/index.html
Outdated
| @@ -220,6 +220,17 @@ <h1><a href="https://developers.google.com/blockly/">Blockly</a> > Demos</h1> | |||
| <div>Build custom blocks and setup a toolbox using Blockly.</div> | |||
| </td> | |||
| </tr> | |||
| <tr> | |||
| <td> | |||
| <a href="code/index.html"> | |||
demos/keyboard-nav/index.html
Outdated
| You can then use the WASD keys to move around the workspace or click the show | ||
| demo button to display an alternative way to navigate the workspace. The demo | ||
| uses <a href="https://en.wikipedia.org/wiki/Tree_traversal#Pre-order_(NLR)">pre | ||
| order tree raversal</a> as an alternative way to navigate the blocks, |
There was a problem hiding this comment.
raversal -> traversal
demos/keyboard-nav/index.html
Outdated
| <h1><a href="https://developers.google.com/blockly/">Blockly</a> > | ||
| <a href="../index.html">Demos</a> > Keyboard Navigation</h1> | ||
|
|
||
| <p>You can enter keyboard navigation mode by <b>shift click anywhere on the |
There was a problem hiding this comment.
shift click -> shift clicking
demos/keyboard-nav/index.html
Outdated
| <!-- <p>→ More info on <a href="">Keyboard Navigation</a>.</p> --> | ||
|
|
||
| <p> | ||
| <button onclick="showDemo()">Show Demo</button> |
There was a problem hiding this comment.
What about "Show Traversal" (and update other references) instead of "Show Demo"?
rachel-fenichel
approved these changes
May 17, 2019
|
Note: the failing tests on Travis are the mocha tests, and it's failing with "null tests failed". I still need to look into that, but it doesn't block this PR. (If I can't fix it soon I'm going to disable it so we have a clear signal from Travis again.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Adds accessibility demo.
Also removes unnecessary import Blockly.BlockSvg.render because it was breaking everything.
Reason for Changes
Test Coverage
Tested on:
Additional Information