Clear debug rectangles before rerendering #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
force-pushed
the
render/pesky_rectangles
branch
from
9ba2d86
to
8b85f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details
Resolves
Debug rectangles were handy if you were rendering a block once, but failed if you were testing how a block resizes in response to changes, because they just kept piling up on top of each other.
Proposed Changes
Turn the debug namespace into a class and save an instance of it on the block. Use that instance for repeated debugging, and clear old nodes and references to them before drawing new ones.
I didn't try to match new nodes to old nodes and just update the old values, mostly because this is easier and less likely to act strangely around mutators.
I also added documentation to all of the functions in
block_rendering_debug.js.Reason for Changes
Make debug visualizations useful in more cases.