Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering tweaks #2477

Merged
merged 1 commit into from
May 22, 2019
Merged

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

  • top left corner highlight was too thick on a square corner
  • empty rows between statement inputs were too short
  • fields were centered vertically in rows. It's good to be able to do it, but this change makes it match the current rendering and leaves a clear place to change field vertical alignment.

Proposed Changes

  • topRow no longer has a squareCorner property, so check the element instead
  • One extra condition in getSpacerRowHeight_
  • pull centerline calculation out into its own function

Copy link
Contributor

@alschmiedt alschmiedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rachel-fenichel rachel-fenichel merged commit affce35 into google:render/collab May 22, 2019
@rachel-fenichel rachel-fenichel deleted the render/tweaks branch May 22, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants