Refactors bottom row to be a row instead of measurable #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -188,6 +190,25 @@ Blockly.BlockRendering.RenderInfo.prototype.createTopRow_ = function() { | |||
| } | |||
| }; | |||
|
|
|||
| /** | |||
| * Create the top row and fill the elements list with all non-spacer elements | |||
| @@ -237,7 +258,7 @@ Blockly.BlockRendering.RenderInfo.prototype.addElemSpacing_ = function() { | |||
| var oldElems = row.elements; | |||
| row.elements = []; | |||
| // No spacing needed before the corner on the top row. | |||
| @@ -341,13 +366,17 @@ Blockly.BlockRendering.RenderInfo.prototype.getInRowSpacing_ = function(prev, ne | |||
| } | |||
|
|
|||
| // Spacing between a rounded corner and a previous connection | |||
There was a problem hiding this comment.
Update comment, here and below.
| // If we have an empty block add a spacer to increase the height | ||
| if (prev.type === 'top row' && next.type === 'bottom row') { | ||
| return BRC.EMPTY_BLOCK_SPACER_HEIGHT; | ||
| } | ||
| // Top row acts a spacer so we don't need any extra padding |
There was a problem hiding this comment.
Update comment to describe bottom row as well.
|
|
||
| this.hasPreviousConnection = !!block.previousConnection; | ||
| this.connection = block.previousConnection; | ||
|
|
||
| var precedesStatement = block.inputList.length && | ||
| block.inputList[0].type == Blockly.NEXT_STATEMENT; | ||
|
|
||
| // | ||
| // This is the minimum height for the row. If one of it's elements has a greater |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Turns the bottom row into a row so that it can hold elements such as corner and next connection.
Reason for Changes
Test Coverage
Tested on:
Additional Information