Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants for width and height of empty inline inputs. #2489

Merged
merged 1 commit into from
May 24, 2019
Merged

Use constants for width and height of empty inline inputs. #2489

merged 1 commit into from
May 24, 2019

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Proposed Changes

Removes some magic numbers and fixes width.
Adds chromedriver to .gitignore.

alschmiedt
alschmiedt approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@alschmiedt alschmiedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rachel-fenichel rachel-fenichel merged commit de8adbe into google:render/collab May 24, 2019
@rachel-fenichel rachel-fenichel deleted the render/empty_inline_input_size branch May 24, 2019 17:52
@rachel-fenichel rachel-fenichel mentioned this pull request Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alschmiedt alschmiedt alschmiedt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rachel-fenichel @alschmiedt