Angle Field Fixes #2501
Merged
Angle Field Fixes #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilFraser
reviewed
May 27, 2019
core/field_angle.js
Outdated
| @@ -295,6 +307,7 @@ Blockly.FieldAngle.prototype.updateGraph_ = function() { | |||
| } | |||
| // Always display the input (i.e. getText) even if it is invalid. | |||
| var angleDegrees = Number(this.getText()) + Blockly.FieldAngle.OFFSET; | |||
| angleDegrees = angleDegrees % 360; | |||
There was a problem hiding this comment.
This is a rare opportunity to use the %= operator.
angleDegrees %= 360;
While you're at it, there's another opportunity for a %= in Blockly.FieldAngle.prototype.doClassValidation_.
There was a problem hiding this comment.
Oooo fun! :D
Fixed
3 tasks
|
@NeilFraser does this look good to you now? |
rachel-fenichel
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
N/A
Proposed Changes
Reason for Changes
It was broken. (The below is a clockwise angle field)
It was always displaying between 0 and 360. It's pretty confusing if it changes when you close th editor.
This just bugged me.
Angle fields should always display a number value (this is different from pure text inputs, which can be empty).
Test Coverage
I tested lots of combinations of CLOCKWISE, OFFSET, and WRAP. Here are some highlights:
Clockwise, Offset 90
Widdershins, Offset 90
Widdershins, Wrap 180
Widdershins, Wrap 180, Offset 90
And here's it now working with the empty string:
Tested on:
Additional Information
N/A