Replace Element constants with Node constants. #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Element constants apparently don’t exist in IE or Edge. Node constants apparently do.
|
Why was this working before #2468? |
|
Okay. The most recent source hasn't hit master, so that's no surprise. The other has been on master for a while so I'm a bit surprised that we haven't seen it before. LGTM, approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element constants don’t exist in IE or Edge. Node constants do.
(Note that old versions of some browser doesn't have Node constants either. Can't remember which browser (Netscape 4, IE 5?) but doesn't affect us. This is why older front-end devs just use raw numbers; we all know that 1 and 3 refer to elements and text respectively.)