Moved the Date Field to the Dropdown Div, and Restyled It #2517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
N/A
Proposed Changes
Note: The darker colour denotes "Today" and the lighter colour denotes the selected day. It is based on how G-cal's mini-calendar looks:
Reason for Changes
Both of which look ugly (imo).
Test Coverage
The closure date picker is missing some functionality that we need, which is the ability to undo a date selection. Because there's no perfect way to do this, the date field has some quirky behavior when dealing with null validators. But as no one uses date fields, and especially no one validates them, I think this is ok.
Closing and Reopening:
Today Button:
Correctly Updating When Month Changes 1:
Correctly Updating when Month Changes 2:
Not Updating for Nulls:
Validated Values Updating:
And here's the bit of odd behavior I mentioned. If you are looking at a different month than the one containing the currently selected date, and you select a new date that validates to null, it will bump you back to the old month:
There's no reasonable way to get around this with closure's current DatePicker API.
Tested on:
Additional Information
N/A