Fix checkbox rendering #2521
Merged
Fix checkbox rendering #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
May 29, 2019
| @@ -288,7 +288,8 @@ Blockly.BlockRendering.Drawer.prototype.drawInternals_ = function() { | |||
| Blockly.BlockRendering.Drawer.prototype.dealWithJackassFields_ = function(field) { | |||
There was a problem hiding this comment.
Wasn't there suppose to be a TODO to remove this method before it goes into master?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details
Resolves
It looked like this before:
Proposed Changes
getComputedSizeto include the size of the border rect.Reason for Changes
Checkboxes were allocated too little space, and offset when rendered.
Test Coverage
test_fields_checkbox screenshot diff now passes.