Adds minimum block height #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -639,6 +639,12 @@ Blockly.BlockRendering.RenderInfo.prototype.finalize_ = function() { | |||
| this.blockBottom = yCursor; | |||
There was a problem hiding this comment.
Check whether we're still using blockBottom. If we are, your change to the yCursor needs to be above this line. If not, add an item to the gnosis to delete it.
There was a problem hiding this comment.
Doesn't look like we are using it. Will add a task for cleanup in gnosis.
|
Looks good, please check why the tests are failing. |
|
Ran tests locally and both passed. Looks like it is not related to this change so will merge and continue investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Problem with some rows not having the correct padding on the bottom row.
Proposed Changes
Add height to the bottom row if the current height does not meet the minimum heigh requirement.
Reason for Changes
Test Coverage
Tested on:
Additional Information