Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dropdown Arrow Missing Padding #2528

Merged
merged 1 commit into from
May 31, 2019

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#2527

Proposed Changes

Readds dropdown arrow padding.

Reason for Changes

Never supposed to be removed.

Test Coverage

DropdownPadding_Empty
DropdownPadding_WithText

Tested on:

  • Desktop Chrome

Additional Information

I don't know if this is /the best/ way to handle padding, but it's how it worked before.

@rachel-fenichel rachel-fenichel merged commit 7c5a94d into google:develop May 31, 2019
@BeksOmega BeksOmega deleted the fixes/DropdownRendering branch June 2, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants