Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
N/A
Proposed Changes
Removes extra calls to
hideWithoutAnimation()
andclearContent()
Reason for Changes
Duplicate work is bad.
Test Coverage
Every gesture starts with a call to hideChaff, which calls
hideWithoutAnimation
, which callsclearContent
. So there's no reason for fields to call hide as well.Here's a gif of before (observe the duplicate calls):
And a pic of the logs:
Here's a gif of it still working (observe no duplicate calls):
Tested on:
Additional Information
N/A