Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Extra DropDownDiv Calls #2532

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

N/A

Proposed Changes

Removes extra calls to hideWithoutAnimation() and clearContent()

Reason for Changes

Duplicate work is bad.

Test Coverage

Every gesture starts with a call to hideChaff, which calls hideWithoutAnimation, which calls clearContent. So there's no reason for fields to call hide as well.

Here's a gif of before (observe the duplicate calls):
Divs_DoubleLogsGif

And a pic of the logs:
Divs_DoubleLogsPic

Here's a gif of it still working (observe no duplicate calls):
Divs_SingleLogsGif

Tested on:

  • Desktop Chrome

Additional Information

N/A

@RoboErikG RoboErikG merged commit 54eb726 into google:develop Jun 3, 2019
@BeksOmega BeksOmega deleted the fixes/HidingDivs branch June 6, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants