Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text y location on statement inputs #2539

Merged

Conversation

rachel-fenichel
Copy link
Collaborator

In current rendering, text on inline inputs and statement inputs is placed a set distance below the top of the row. I had two different constants for this, but that was masking a different error.

If/when we switch to vertically centering the fields in a row, this goes away entirely.

@rachel-fenichel
Copy link
Collaborator Author

Tests passing: 81/109

@rachel-fenichel rachel-fenichel merged commit cad4430 into google:render/collab Jun 4, 2019
@rachel-fenichel rachel-fenichel deleted the render/statements branch June 4, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants