Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render/rtl top right #2548

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Render/rtl top right #2548

merged 2 commits into from
Jun 5, 2019

Conversation

rachel-fenichel
Copy link
Collaborator

Two changes:

  • Correctly check RTL mode and use BRC constants instead of Blockly.BlockSvg constants for the top-right-corner highlight in RTL mode (chops off an extra tail)
  • Shift the previous connection highlight by BRC.HIGHLIGHT_OFFSET. This fixes a slight misalignment that show up when you have blocks stacked vertically.

@rachel-fenichel rachel-fenichel merged commit ca6ee2b into google:render/collab Jun 5, 2019
@rachel-fenichel rachel-fenichel deleted the render/rtl_top_right branch June 5, 2019 22:47
@rachel-fenichel rachel-fenichel mentioned this pull request Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoboErikG RoboErikG RoboErikG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rachel-fenichel @RoboErikG