Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up inline and external value input highlighting #2550

Conversation

rachel-fenichel
Copy link
Collaborator

This addresses problems with these blocks and similar ones in RTL:
image

Previously the inline inputs didn't have a highlight for the top right side (above the tab). There were also a bunch of magic numbers to put things in the right places.

Changes:

  • Added top right side highlighting.
  • Removed extra magic numbers from the rtl tab highlight.
  • The above broke external value inputs, so I also fixed those.
  • Removed vertical line below the tab from the tab highlight path.

@rachel-fenichel rachel-fenichel merged commit 8ea2c7f into google:render/collab Jun 6, 2019
@rachel-fenichel rachel-fenichel deleted the render/inline_input_highlight_rtl branch June 6, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants