Added Trashcan Tests #2568
Added Trashcan Tests #2568
Conversation
There was a problem hiding this comment.
Create an issue for those TODOs and tag it in the comment as TODO (#issueNumber) so we don't completely lose track of them.
I see what you mean about the behaviour being a little wrong. The alternative would be to do much more parsing, on arbitrarily large chunks of xml, so I vote we leave it as a low-priority issue.
tests/mocha/trashcan_test.js
Outdated
|
|
||
| suite("Events", function() { | ||
| test("Delete", function() { | ||
| sendDeleteEvent( |
There was a problem hiding this comment.
sendDeleteEvent can add the <xml> and </xml> tags to remove duplication.
Done. When I was creating the issue I noticed that the problems with the |
The basics
The details
Resolves
N/A
Proposed Changes
Adds tests to documenta trashcan behavior.
Reason for Changes
To keep Beka from breaking things.
Test Coverage
This is tests silly!
Additional Information
The tests document the current behavior of the trashcan, but I don't think all of that behavior is good. I left TODO's in places where I think behavior should be changed.
Also this might not cover everything that needs to be tested. If you have suggestions I'd love to add more tests.