Added Sending the Bad Value to doValueInvalid #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
requested review from
rachel-fenichel and
alschmiedt
and removed request for
rachel-fenichel
NeilFraser
reviewed
Jun 24, 2019
core/field_textinput.js
Outdated
| * @protected | ||
| */ | ||
| Blockly.FieldTextInput.prototype.doValueInvalid_ = function() { | ||
| Blockly.FieldTextInput.prototype.doValueInvalid_ = function(_newValue) { |
There was a problem hiding this comment.
What does this underscore signify? I'm not familiar with such a naming scheme.
There was a problem hiding this comment.
I believe that it's just a thing for the eslint, so that it doesn't freak out about an unused variable.
alschmiedt
reviewed
Jun 24, 2019
core/field_textinput.js
Outdated
| * @protected | ||
| */ | ||
| Blockly.FieldTextInput.prototype.doValueInvalid_ = function() { | ||
| Blockly.FieldTextInput.prototype.doValueInvalid_ = function(_newValue) { |
There was a problem hiding this comment.
Actually thinking about this could you change _newValue to something like _invalidValue? I think it is a bit more clear. sorry for the late comment!
There was a problem hiding this comment.
Makes sense! Can do =)
alschmiedt
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
N/A
Proposed Changes
doValueInvalid_() now recieves the invalid value.
Reason for Changes
Makes it easier for fields to display invalid values if they wish.
This was not added previously because the only core field that uses doValueInvalid is the text input field, and its display value is stored on the htmlInput. But when I was working on the custom fields demo I found that this was useful.
Test Coverage
N/A
Additional Information
N/A