Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gulp to v4 #2583

Merged
merged 1 commit into from
Jun 21, 2019
Merged

upgrade gulp to v4 #2583

merged 1 commit into from
Jun 21, 2019

Conversation

nicholascioli
Copy link
Contributor

As of NodeJS v12.4.0, gulp v3 fails to run at all. This small change
should allow for future compatibility with NodeJS.

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Resolves: #2582

Proposed Changes

This pull request will update gulp to v4 and also update the gulpfile to use
the new v4 syntax.

Reason for Changes

Without this change, any attempt to use blockly in a NodeJS (or NodeJS-built) v12.4.0 project fails.

Test Coverage

Tested on:

  • Desktop Chrome
  • Desktop Firefox
  • Desktop Safari

Additional Information

As of NodeJS v12, gulp v3 fails to run at all. This small change
should allow for future compatibility with NodeJS.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nicholascioli
Copy link
Contributor Author

nicholascioli commented Jun 21, 2019 via email

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@rachel-fenichel
Copy link
Collaborator

Thanks for providing both the bug report and the solution!

@rachel-fenichel rachel-fenichel merged commit 2d334c1 into google:develop Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants