Build script updates #2589
Merged
Build script updates #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o build_script_updates
RoboErikG
reviewed
Jun 26, 2019
build.py
Outdated
| render_path = 'core/renderers/' + args.render_name | ||
| core_search_paths = calcdeps.ExpandDirectories(directories) | ||
| for path in core_search_paths: | ||
| #If it is the desired renderer |
There was a problem hiding this comment.
nit space after # here and below
tests/compile/compile.sh
Outdated
| echo "Compiling Blockly..." | ||
| COMPILATION_COMMAND="java -jar $COMPILER --js='$BLOCKLY_ROOT/tests/compile/main.js' \ | ||
| --js='$BLOCKLY_ROOT/core/**.js' \ | ||
| --js='$BLOCKLY_ROOT/tests/compile/temp_core/**.js' \ |
There was a problem hiding this comment.
This should reference the tempPath variable -> '$tempPath/**.js'
tests/compile/compile.sh
Outdated
| fi | ||
|
|
||
|
|
||
| tempPath="$BLOCKLY_ROOT/tests/compile/temp_core" |
There was a problem hiding this comment.
Why is this under tests? It's more common to see an output or a build directory at the root of the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Reason for Changes
Test Coverage
Tested on:
Additional Information