Create svg_utils file #2597
Merged
Create svg_utils file #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @NeilFraser @RoboErikG for API/naming comments. |
NeilFraser
reviewed
Jun 28, 2019
NeilFraser
reviewed
Jun 28, 2019
NeilFraser
reviewed
Jun 28, 2019
NeilFraser
reviewed
Jun 28, 2019
NeilFraser
approved these changes
Jun 28, 2019
core/utils/svg_paths.js
Outdated
| * See developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths#Line_commands | ||
| * @param {!Array.<string>} points An array containing all of the points to | ||
| * draw lines to, in order. The points are represented as strings of the | ||
| * format ' dx, dy '. |
There was a problem hiding this comment.
There's no space after the comma.
core/utils/svg_paths.js
Outdated
| * These coordinates are unitless and hence in the user coordinate system. | ||
| * See developer.mozilla.org/en-US/docs/Web/SVG/Attribute/d#LineTo_path_commands | ||
| * @param {string} command The command to prepend to the coordinate. This | ||
| * should be one of: V, v, H, h. See |
There was a problem hiding this comment.
Oh say can you see ... what?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
No issue
Proposed Changes
Create a set of helper functions for making SVG path commands.
Reason for Changes
SVG paths are defined as strings. There are a variety of commands, each represented by a single character and a sequence of numbers. These commands are really hard to read in the current code:
These functions make the SVG path code more readable, and also remove some of the confusion around number addition vs string concatenation. It also makes it easier to see when we're using negative numbers.
This is a proposed API. I would like to keep the names relatively short, since
Blockly.utils.Somethingis already pretty long. I could be convinced that it should beSVGPathsinstead ofPaths.We're not using these functions anywhere yet, so now is the time to pick names.