Fixes theme error for headless workspaces #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. One jsunit test is failing. |
tests/jsunit/block_test.js
Outdated
| @@ -279,6 +280,7 @@ function test_set_style() { | |||
| assertEquals('#ddeeff', blockA.colourTertiary_); | |||
|
|
|||
| blockTest_tearDown(); | |||
| \ | |||
rachel-fenichel
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#2575 & #2540
Proposed Changes
Set a default theme in the workspace constructor.
Reason for Changes
We were getting an error when creating a block on a headless workspace because the theme was not set. This is because we only set the default theme in Blockly.Inject which does not get called for a headless workspace.
Test Coverage
Tested on:
Additional Information