Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug with using dynamic variable in toolbox #2618

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Fixes bug with using dynamic variable in toolbox #2618

merged 2 commits into from
Jul 9, 2019

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#2557

Proposed Changes

  1. Use getVariable() instead of getVariableById(). getVariable looks through both the potential variable map as well as the variable map. This fixes the original error.
  2. Look through the potential variable map and the regular variable map when getting variable types. This fixes the error we were getting when we have a block like the one below that accepts any type.

Screen Shot 2019-07-09 at 11 16 42 AM

Reason for Changes

Test Coverage

Tested on:

Additional Information

@alschmiedt alschmiedt merged commit 6e9761b into google:develop Jul 9, 2019
@rachel-fenichel rachel-fenichel mentioned this pull request Jul 15, 2019
Merged
@alschmiedt alschmiedt deleted the dynamic_variable_error branch May 29, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alschmiedt @rachel-fenichel