Remove accessibility demo from Blockly repo #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alschmiedt
reviewed
Jul 9, 2019
| # build.py with no parameters builds all files. | ||
| # core builds blockly_compressed, blockly_uncompressed, and blocks_compressed. | ||
| # accessible builds blockly_accessible_compressed, | ||
| # blockly_accessible_uncompressed, and blocks_compressed. | ||
| # generators builds every <language>_compressed.js. | ||
| # langfiles builds every msg/js/<LANG>.js file. | ||
|
|
There was a problem hiding this comment.
Should the below say the script generates two versions? And remove the "first pair" part?
alschmiedt
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accessibility demo now lives in a new repository, blockly-experimental.
The Blockly team will no longer maintain compatibility with the demo code, but we want to keep it around as an interesting artifact.
Our accessibility work is now focused on keyboard navigation in Blockly itself, rather than in a fully distinct renderer for use with screen readers. As of July 8 2019 that code is in the keyboard_nav branch, and it will land in develop in the next release.
The first commit deletes the accessible folder and sets up the demo to redirect.
The second commit removes it from the build process.
@alschmiedt to look at build.py
Fixes #2565