Procedures test workspace cleanup #4311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Closes #4080
Proposed Changes
procedures_callreturn
andprocedures_callnoreturn
rather than usethis.callForAllTypes
.try
/finally
blocks withworkspaceTeardown
where appropriateblock.dispose
calls (handled inWorkspace.dispose
)deleteVariable
calls (each test has its ownWorkspace
)Reason for Changes
procedures_callnoreturn
(was run first) then test was not run forprocedures_callreturn. This makes it easier to debug if there is a bug specific to
procedures_callreturnor
procedures_callnoreturn`Test Coverage
Ran mocha tests
Tested on:
Documentation
n/a
Additional Information
Behavior of tests unchanged.