Refactor FieldImage tests to use dev-tools helpers #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moniika
force-pushed
the
field-image-test-refactor-dev-tools
branch
from
a20bbb2
to
1761992
Compare
samelhusseini
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #4260
Proposed Changes
Refactors FieldImage tests to use dev-tools helpers.
Reason for Changes
Improves readability and coverage.
Test Coverage
Tested by setting temporary link to local built files of dev-tools (with necessary changes) and running mocha tests.
Tested on:
Additional Information
Depends on PR in Blockly-Samples google/blockly-samples#381, now published so changes can be used.