Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block factory fix #4327

Merged
merged 4 commits into from Sep 28, 2020
Merged

Block factory fix #4327

merged 4 commits into from Sep 28, 2020

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Block factory was broken due to:

  1. Using Blockly.Options.parseToolbox instead of Blockly.utils.toolbox.parseToolbox
  2. Toolbox Items use the given id on the <category> element when creating the html for the toolbox. This causes problems since the <category> xml has the same id.

Proposed Changes

  1. Use Blockly.utils.toolbox.parseToolbox.
  2. . Use a different name for the id so that there are not two elements on the page with the same id.

Reason for Changes

Test Coverage

Tested on:

Documentation

Additional Information

I could potentially keep it as id for JSON and change it for xml but I thought this would be more confusing. So changing the name for both.

@rachel-fenichel
Copy link
Collaborator

LGTM, but should we be concerned about breaking others in the same way? We could deprecate Blockly.Options.parseToolboxTree (mark as deprecated with warnings) and have it call through to the new function.

@alschmiedt
Copy link
Contributor Author

At the time I couldn't think of any use cases outside of core, but I think this proves there are some so happy to add back in.

@alschmiedt alschmiedt merged commit 3d698f4 into google:develop Sep 28, 2020
alschmiedt added a commit to alschmiedt/blockly that referenced this pull request Sep 28, 2020
@alschmiedt alschmiedt mentioned this pull request Sep 28, 2020
3 tasks
alschmiedt added a commit that referenced this pull request Sep 28, 2020
* Block factory fix (#4327)

* Rebuild
@KlemenDEV
Copy link

The patch release is called "Q4 2020 Patch 1" but should probably be "Q3 2020 Patch 1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants