Add test-blocks into the basic playground #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, get test blocks in the basic playground from npm
samelhusseini
changed the title
alschmiedt
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Add test-blocks back into the basic playground.
Proposed Changes
Switch from unpkg to using local node_modules for advanced playground dev-tools.
Add alert if npm install is not yet run.
Get test blocks from @blockly/block-test package in basic playground.
Reason for Changes
X-browser testing with test blocks in basic playground.
Test Coverage
Tested basic playground with test blocks on IE11, Edge 18, Edge 80, and Chrome.
Documentation
Additional Information
Relies on a publish of the @blockly/block-test package in google/blockly-samples#384
After publish, re-run npm install, to update package-lock.json here.