select text on comment open #4349
Conversation
|
I think the original issue has to do with workspace comments instead of block comments. You can create a workspace comment by right clicking on the workspace and selecting "Add Comment" from the context menu. If you are still interested in working on this issue I think looking in workspace_comment_svg.js would be a good starting place. I would also mention, that it should only highlight the workspace comment if it has the default text. Thanks! |
|
Wow I have misunderstood this one 😄 Going to fix it asap! Thanks for the input! |
|
done! 😄 |
core/workspace_comment_svg.js
Outdated
| if (this.textarea_) { | ||
| this.textarea_.select(); | ||
| } |
There was a problem hiding this comment.
I think this is on the right track!
My only concern is that this initSvg method will get called in fromXml which will cause all of the comments to be selected when someone loads a workspace from xml. This can be tested by going to the playground, creating a workspace comment, changing the text, and then hitting the "Export to XML" and the "Import from XML" buttons.
I think this can be fixed if we add an optional parameter to this method that can be passed in as true in fromXml. We can then check that the optional parameter is false before selecting the area.
Thanks! And let me know if you have any questions!
There was a problem hiding this comment.
Thanks for the help!
I am not sure about the final status: :
I created a new boolean parameter deSelectText if it is false I am selecting the text
From fromXml method I set the flag to true.
It feels a bit strange to me, especially with the variable name, let me know what you think!
again thanks for the help!
|
It should be fixed now |
|
Hmm looks like the build failed due to a missing file I deleted it since it was not intended to be committed. |
There was a problem hiding this comment.
The files that were accidentally added shouldn't be deleted, they should just be reverted to their previous state. You should be able to do something like:
git checkout <commit> filename.
The only change for the pr should be in workspace_comment_svg.js.
Thanks for the updates! I know getting the compressed files wrapped up in a pr can be a pain : ) I have definitely done it a few times.
core/workspace_comment_svg.js
Outdated
| @@ -145,9 +145,12 @@ Blockly.WorkspaceCommentSvg.prototype.dispose = function() { | |||
| /** | |||
| * Create and initialize the SVG representation of a workspace comment. | |||
| * May be called more than once. | |||
| * | |||
| * @param {boolean=} deSelectText Text inside text area will be selected if false | |||
There was a problem hiding this comment.
This comment needs to be updated to use opt_noSelect
There was a problem hiding this comment.
Ok now things looks better 😄
|
This looks good, but there is still one file that needs to be reverted |
The basics
The details
Resolves
#1863
Proposed Changes
Selects the text inside a comment box when it is opened
Reason for Changes
To solve the issue at hand
Test Coverage
For each platform I have used tests/playground.html and created a function to open comment
Tested on:
Desktop Chrome
Desktop Firefox
Documentation
No it was not, though I would be willing to update it if need be.
Additional Information