Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Blockly.onKeyDown method #4373

Merged
merged 2 commits into from Oct 16, 2020

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

Add tests for Blockly.onKeyDown.

Reason for Changes

So I can refactor things without breaking everything.

Test Coverage

Tested on:

Documentation

Additional Information

Copy link
Contributor

@moniika moniika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor nits about naming.

tests/mocha/keydown_test.js Outdated Show resolved Hide resolved
tests/mocha/keydown_test.js Outdated Show resolved Hide resolved
@alschmiedt alschmiedt merged commit 7eb9c49 into google:develop Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants