Set data-id on block svgs for IE11 #4425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
data-id
on blocks' svg groups usingsetAttribute()
, notdataset
for IE.The basics
The details
Resolves
#4419
Proposed Changes
Sets the
data-id
usingsetAttribute
for IEReason for Changes
We use the data-id from the SVG group to interact with blocks in UI tests, so this is needed to be able to test in IE
Test Coverage
Tested in the playground
Tested on:
Desktop Chrome
Windows IE 11
Documentation
Additional Information