Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set data-id on block svgs for IE11 #4425

Merged
merged 1 commit into from Nov 2, 2020
Merged

Set data-id on block svgs for IE11 #4425

merged 1 commit into from Nov 2, 2020

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Nov 2, 2020

Set data-id on blocks' svg groups using setAttribute(), not dataset for IE.

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#4419

Proposed Changes

Sets the data-id using setAttribute for IE

Reason for Changes

We use the data-id from the SVG group to interact with blocks in UI tests, so this is needed to be able to test in IE

Test Coverage

Tested in the playground

Tested on:

  • Desktop Chrome
    image

  • Windows IE 11
    blockly

Documentation

Additional Information

@google-cla
Copy link

google-cla bot commented Nov 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ajpal
Copy link
Contributor Author

ajpal commented Nov 2, 2020

@googlebot I signed it!

@samelhusseini samelhusseini merged commit eff3fcc into google:develop Nov 2, 2020
@samelhusseini
Copy link
Contributor

Thank you for your PR!

@ajpal ajpal deleted the svg-dataset-id-ie11 branch November 2, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants