Add fix for display text on multiline text block

[moniika]

The basics

• I branched from develop
• My pull request is against develop
• My code follows the style guide

The details

Resolves

n/a

Proposed Changes

Fixed logic in getDisplayText_ for FieldMultilineText to use getText rather than this.value_ directly.

Reason for Changes

Due to the logic in getDisplayText_, rendering of editor text for FieldMultilineText was acting up in cases where the validator returned a string of different size. This is because there is extra logic in getText that returns the editor text if the field is currently being edited.

Before change:

After change:

Test Coverage

Tested block with FieldMultilineInput and custom validator before and after change:

Blockly.Blocks['text_multiline_validator'] = {
  init: function() {
    this.appendDummyInput()
        .appendField('multiline text input:')
        .appendField(
            new Blockly.FieldMultilineInput('default', this.validate), 'INPUT');
    this.setColour('#5ba58c');
  },

  validate: function(newValue) {
    return newValue.replace(/a/gm, '');
  },
};

Tested on:

Additional Information

Issue found while writing documentation for multiline text field