Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build scripts #4558

Merged
merged 17 commits into from Jan 8, 2021
Merged

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

  1. Adds a script for publishing beta version. This relies on user input about the version since I think we want this to be next.release.version-beta.0. However, it checks that -beta. is present and that the version doesn't already exist.
  2. Publish script -- Packages, checks with the user they are on the correct branch, checks the dist folder for certain files, and then will login and publish.
  3. recompile script -- Updated to ask the user whether to update, patch, minor, or major version.
  4. Delete package from require cache whenever we get the version number. Not deleting it was causing us to get the incorrect version in blockly_compressed.js.

Reason for Changes

  1. There are few extra steps for releasing a beta version that we do not want to mess up.
  2. Basically same.
  3. I almost forgot to update the major version this release, which would have been a medium ish headache.

Test Coverage

Tested on:

Documentation

Additional Information

I need to uncomment the line that will actually publish.
I will do that and merge after I have a chance to test releasing beta version, or patch, or something with new script.
I can also add a dryrun version similar to samples if people think that would be helpful.

@moniika moniika self-requested a review January 5, 2021 19:02
Comment on lines 109 to 110
// TODO: Uncomment this line and test.
// execSync('npm publish --registry https://wombat-dressing-room.appspot.com', {cwd: RELEASE_DIR, stdio: 'inherit'});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this TODO be removed or is this something that still needs to be tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be here. I am waiting for when we need to publish a patch, or beta version so that I can test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Could you change to "Uncomment this line and test the next time we publish a patch, or beta version." and/or maybe create an issue that can be linked.
Then others with less context know what that's in there for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, so uncommenting this line and removed the npm pack above.

scripts/gulpfiles/build_tasks.js Outdated Show resolved Hide resolved
scripts/gulpfiles/git_tasks.js Show resolved Hide resolved
scripts/gulpfiles/release_tasks.js Outdated Show resolved Hide resolved
@moniika moniika self-assigned this Jan 5, 2021
@alschmiedt alschmiedt merged commit 1208987 into google:develop Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants