New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build scripts #4558
Update build scripts #4558
Conversation
scripts/gulpfiles/release_tasks.js
Outdated
// TODO: Uncomment this line and test. | ||
// execSync('npm publish --registry https://wombat-dressing-room.appspot.com', {cwd: RELEASE_DIR, stdio: 'inherit'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this TODO be removed or is this something that still needs to be tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be here. I am waiting for when we need to publish a patch, or beta version so that I can test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. Could you change to "Uncomment this line and test the next time we publish a patch, or beta version." and/or maybe create an issue that can be linked.
Then others with less context know what that's in there for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested, so uncommenting this line and removed the npm pack above.
The basics
The details
Resolves
Proposed Changes
blockly_compressed.js
.Reason for Changes
Test Coverage
Tested on:
Documentation
Additional Information
I need to uncomment the line that will actually publish.
I will do that and merge after I have a chance to test releasing beta version, or patch, or something with new script.
I can also add a dryrun version similar to samples if people think that would be helpful.