Flyout metrics #4684
Merged
Flyout metrics #4684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moniika
approved these changes
Mar 8, 2021
core/metrics_manager.js
Outdated
Comment on lines
615
to
619
| if (this.flyout_.horizontalLayout) { | ||
| return this.getHorizontalViewMetrics_(opt_getWorkspaceCoordinates); | ||
| } else { | ||
| return this.getVerticalViewMetrics_(opt_getWorkspaceCoordinates); | ||
| } |
There was a problem hiding this comment.
I don't think we need separate getHorizontalViewMetrics_ and getVerticalViewMetrics_ methods. I would instead just check for horizontal layout inside the method when you subtract the scrollbar padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Flyout workspaces should use their own metrics manager.
Behavior Before Change
Behavior After Change
Reason for Changes
Test Coverage
Documentation
Additional Information
I am fairly confident this matches the old behavior. However, I am not confident yet that the metrics are correct. There still looks like there is something weird going on with the absolute and view metrics.