Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace object.mixin with Object.assign #6138

Merged
merged 2 commits into from
May 4, 2022
Merged

fix: replace object.mixin with Object.assign #6138

merged 2 commits into from
May 4, 2022

Conversation

derwehr
Copy link
Contributor

@derwehr derwehr commented May 4, 2022

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

#5914

Proposed Changes

Replaces all uses of object.mixin with Object.assign

Behavior Before Change

Behavior After Change

Reason for Changes

see #5914

Test Coverage

Documentation

Additional Information

Things I didn't do, because I was unsure if they're needed or wanted:

  • update any documentation
  • declare object.mixin as deprecated

@derwehr derwehr requested a review from a team as a code owner May 4, 2022 09:02
@derwehr derwehr requested a review from BeksOmega May 4, 2022 09:02
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for posting this! And thank you for removing the goog.require calls as well.

I think we should definitely deprecate the object.mixin function, so that we don't accidentally use it in the future. Here is a good example of how to deprecate something.

  1. Add an @deprecated tag recording what to use instead, and when the function was deprecated.
  2. Add a call to Blockly.utils.deprecation.warn with similar info. The deletionDate should be May 2023.

Thank you again for posting this fix! We really appreciate it =)

@derwehr derwehr requested a review from BeksOmega May 4, 2022 19:52
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you again :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants