Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build)!: compile to ES2015 instead of ES5 #6335

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6328

Proposed Changes

Set the closure compiler to compile to ES2015 instead of ES5.

Behavior Before Change

blockly_compressed.js could be used directly in ES5 environments such as Internet Explorer and Firefox < 43.

Behavior After Change

blockly_compressed.js does not work directly in ES5 environments. It can still be transpiled further if needed.

Reason for Changes

Part of #6325

Test Coverage

Rebuild and started the server, and confirmed that I can open and use the playground.

Documentation

Any remaining documentation that says that we support ES5 will need to change by the next release.

Additional Information

The results of check_metadata.sh are:

Size of build/blockly_compressed.js at 862067 compared to previous 1040413.
Size of build/blocks_compressed.js at 102485 compared to previous 102176.
Size of build/blockly_compressed.js.gz at 172738 compared to previous 185766.
Size of build/blocks_compressed.js.gz at 17107 compared to previous 17016.

@rachel-fenichel rachel-fenichel added component: build process breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Aug 10, 2022
@rachel-fenichel rachel-fenichel requested a review from a team as a code owner August 10, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. component: build process PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants