fix: make getSourceBlock nullable again #6542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Oct 13, 2022
BeksOmega
force-pushed
the
fix/get-source-block
branch
from
c20cc4d
to
7eb754b
Compare
cpcallen
pushed a commit
to cpcallen/blockly
that referenced
this pull request
Oct 19, 2022
* fix: make getSourceBlock nullable again * chore: format * chore: move to a specific error * chore: also update procedures with new error * chore: format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
https://groups.google.com/g/blockly/c/IxL-Px8GMXA/m/EK5g2VQ8BwAJ?utm_medium=email&utm_source=footer
Proposed Changes
Makes getSourceBlock nullable again.
Behavior Before Change
No user-facing change in behavior.
Behavior After Change
No user-facing change in behavior.
Reason for Changes
We were breaking people who were using getSourceBlock in callbacks that were called before the field was attached to a block.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A