Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't warn if field is acually 0 width #6558

Merged
merged 2 commits into from Oct 18, 2022
Merged

Conversation

NeilFraser
Copy link
Member

@NeilFraser NeilFraser commented Oct 18, 2022

One part of issue #6557.

Part two is updates to the json translation files (but those go into the translatewiki branch).

@NeilFraser
Copy link
Member Author

Part 2 is committed here: f680d79

@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Oct 18, 2022
core/field.ts Outdated
this.render_();
// Don't issue a warning if the field is actualy zero width.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actualy -> actually

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the spellchecking of comments that Komodo IDE provided.

@NeilFraser NeilFraser merged commit 321f619 into develop Oct 18, 2022
@NeilFraser NeilFraser deleted the fraser-zerowidth branch October 18, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants