Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clang format version bump #6640

Merged
merged 1 commit into from
Nov 21, 2022
Merged

ci: clang format version bump #6640

merged 1 commit into from
Nov 21, 2022

Conversation

piwysocki
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes

Proposed Changes

clang-format 1.8.0 uses format 15

Behavior Before Change

format 13 used

Behavior After Change

format 15 used

Reason for Changes

ci version should be as close as possible to the version that the npm package supports

Test Coverage

Documentation

Additional Information

@piwysocki piwysocki requested a review from a team as a code owner November 20, 2022 19:23
@BeksOmega BeksOmega requested review from BeksOmega and removed request for gonfunko November 21, 2022 21:35
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the bump @piwysocki =)

@BeksOmega BeksOmega merged commit b5180cf into google:develop Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants