-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add running procedure events #6650
Merged
BeksOmega
merged 15 commits into
google:develop
from
BeksOmega:feat/running-procedure-events
Dec 1, 2022
Merged
feat: add running procedure events #6650
BeksOmega
merged 15 commits into
google:develop
from
BeksOmega:feat/running-procedure-events
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
feat/running-procedure-events
branch
from
November 29, 2022 19:25
d1b082d
to
59240d7
Compare
cpcallen
reviewed
Nov 30, 2022
cpcallen
approved these changes
Nov 30, 2022
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Fixes #6519
Proposed Changes
Adds the ability to run procedure events backwards and forwards.
Reason for Changes
This is necessary to support undo and redo, as well as sharing procedures between workspaces.
Test Coverage
Tests were added in #6627 They are now enabled.
Documentation
N/A
Additional Information
N/A