Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add running procedure events #6650

Merged
merged 15 commits into from
Dec 1, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6519

Proposed Changes

Adds the ability to run procedure events backwards and forwards.

Reason for Changes

This is necessary to support undo and redo, as well as sharing procedures between workspaces.

Test Coverage

Tests were added in #6627 They are now enabled.

Documentation

N/A

Additional Information

N/A

core/events/events_procedure_enable.ts Outdated Show resolved Hide resolved
core/events/events_procedure_create.ts Outdated Show resolved Hide resolved
core/events/events_procedure_delete.ts Outdated Show resolved Hide resolved
core/events/events_procedure_create.ts Outdated Show resolved Hide resolved
core/events/events_procedure_change_return.ts Show resolved Hide resolved
core/events/events_procedure_change_return.ts Show resolved Hide resolved
core/events/events_procedure_change_return.ts Show resolved Hide resolved
core/events/events_procedure_create.ts Show resolved Hide resolved
core/events/events_procedure_delete.ts Show resolved Hide resolved
core/events/events_procedure_enable.ts Show resolved Hide resolved
core/events/events_procedure_enable.ts Show resolved Hide resolved
tests/mocha/event_procedure_create_test.js Show resolved Hide resolved
tests/mocha/event_procedure_delete_test.js Show resolved Hide resolved
tests/mocha/event_procedure_parameter_delete_test.js Outdated Show resolved Hide resolved
@BeksOmega BeksOmega merged commit c959ce8 into google:develop Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement running procedure events
3 participants