Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: procedure event serialization #6669

Merged

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Nov 30, 2022

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6601

Proposed Changes

Adds round-tripping procedure events through serialization.

Reason for Changes

To be able to share events between workspaces we need to be able to serialize and deserialize them.

Test Coverage

Tests are now enabled.

Documentation

N/A

Additional Information

Dependent on #6668

@BeksOmega BeksOmega requested a review from a team as a code owner November 30, 2022 17:13
@github-actions github-actions bot added the PR: feature Adds a feature label Nov 30, 2022
@BeksOmega BeksOmega force-pushed the feat/procedure-event-serialization branch from d5acb70 to 08eeac8 Compare December 1, 2022 19:28
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Dec 1, 2022
@BeksOmega BeksOmega mentioned this pull request Dec 1, 2022
4 tasks
@BeksOmega BeksOmega force-pushed the feat/procedure-event-serialization branch from 08eeac8 to 6e9c0e0 Compare December 5, 2022 18:35
@BeksOmega
Copy link
Collaborator Author

This is ready to review whenever!

@BeksOmega BeksOmega force-pushed the feat/procedure-event-serialization branch from 6e9c0e0 to f137643 Compare December 6, 2022 19:10
@BeksOmega BeksOmega merged commit d6230b2 into google:develop Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement serializing procedure events
2 participants